Hi Yangtao, I love your patch! Yet something to improve:
[auto build test ERROR on jaegeuk-f2fs/dev-test] [also build test ERROR on jaegeuk-f2fs/dev linus/master v6.3-rc5 next-20230331] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yangtao-Li/f2fs-support-FAULT_LOCK-type-fault-injection/20230403-111853 base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test patch link: https://lore.kernel.org/r/20230403031723.43870-1-frank.li%40vivo.com patch subject: [PATCH v4] f2fs: support FAULT_LOCK type fault injection config: i386-randconfig-a006-20230403 (https://download.01.org/0day-ci/archive/20230403/202304031801.hgbhuubp-...@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/7a551520921cdc8921f448714472af3014da4f50 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Yangtao-Li/f2fs-support-FAULT_LOCK-type-fault-injection/20230403-111853 git checkout 7a551520921cdc8921f448714472af3014da4f50 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <l...@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202304031801.hgbhuubp-...@intel.com/ All errors (new ones prefixed by >>): In file included from fs/f2fs/dir.c:13: >> fs/f2fs/f2fs.h:2174:60: error: incompatible pointer types passing 'struct >> rw_semaphore *' to parameter of type 'struct f2fs_rwsem *' >> [-Werror,-Wincompatible-pointer-types] wait_event(sem->read_waiters, f2fs_down_read_trylock(sbi, &sem->internal_rwsem)); ^~~~~~~~~~~~~~~~~~~~ include/linux/wait.h:343:6: note: expanded from macro 'wait_event' if (condition) \ ^~~~~~~~~ fs/f2fs/f2fs.h:2164:25: note: passing argument to parameter 'sem' here struct f2fs_rwsem *sem) ^ >> fs/f2fs/f2fs.h:2174:60: error: incompatible pointer types passing 'struct >> rw_semaphore *' to parameter of type 'struct f2fs_rwsem *' >> [-Werror,-Wincompatible-pointer-types] wait_event(sem->read_waiters, f2fs_down_read_trylock(sbi, &sem->internal_rwsem)); ^~~~~~~~~~~~~~~~~~~~ include/linux/wait.h:345:24: note: expanded from macro 'wait_event' __wait_event(wq_head, condition); \ ^~~~~~~~~ include/linux/wait.h:325:31: note: expanded from macro '__wait_event' (void)___wait_event(wq_head, condition, TASK_UNINTERRUPTIBLE, 0, 0, \ ^~~~~~~~~ include/linux/wait.h:310:7: note: expanded from macro '___wait_event' if (condition) \ ^~~~~~~~~ fs/f2fs/f2fs.h:2164:25: note: passing argument to parameter 'sem' here struct f2fs_rwsem *sem) ^ 2 errors generated. vim +2174 fs/f2fs/f2fs.h 2170 2171 static inline void f2fs_down_read(struct f2fs_sb_info *sbi, struct f2fs_rwsem *sem) 2172 { 2173 #ifdef CONFIG_F2FS_UNFAIR_RWSEM > 2174 wait_event(sem->read_waiters, f2fs_down_read_trylock(sbi, > &sem->internal_rwsem)); 2175 #else 2176 down_read(&sem->internal_rwsem); 2177 #endif 2178 } 2179 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
