On Fri, Dec 01, 2023 at 07:03:47PM -0800, Daniel Rosenberg via Linux-f2fs-devel 
wrote:
> +     /* For compatibility with 4K crypto unit size, we must restrict
> +      * the max filesize to what can fit within U32_MAX 4K units.
> +      * Since the blocksize must currently be equal to the page size,
> +      * we can grab that from there. inode is NULL when setting up
> +      * the superblock.
> +      */
> +
> +     result = min(result, ((loff_t) U32_MAX * 4096) >> PAGE_SHIFT);

This should be formatted like:

        /*
         * For compatibility with ...
         */
        result = ...

Also, the comment should mention that this is for the IV_INO_LBLK_64 and
IV_INO_LBLK_32 encryption settings.  There is no issue with the default
encryption setting.

Also, use F2FS_BLKSIZE_BITS instead of PAGE_SHIFT?

Also, the commit message could use:

        Fixes: d7e9a9037de2 ("f2fs: Support Block Size == Page Size")

- Eric


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to