[f2fs-dev] [PATCH v5 03/12] fscrypt: Call fscrypt_prepare_lookup_dentry on unencrypted dentries

[Gabriel Krisman Bertazi]

In preparation to dropping DCACHE_OP_REVALIDATE for dentries that
don't need it at lookup time, refactor the code to make unencrypted
denties also call fscrypt_prepare_dentry.  This makes the
non-inline __fscrypt_prepare_lookup superfulous, so drop it.

Signed-off-by: Gabriel Krisman Bertazi <kris...@suse.de>
---
 fs/crypto/hooks.c       | 14 --------------
 include/linux/fscrypt.h | 31 +++++++++++++++----------------
 2 files changed, 15 insertions(+), 30 deletions(-)

diff --git a/fs/crypto/hooks.c b/fs/crypto/hooks.c
index 71463cef08f9..eb870bc162e6 100644
--- a/fs/crypto/hooks.c
+++ b/fs/crypto/hooks.c
@@ -94,20 +94,6 @@ int __fscrypt_prepare_rename(struct inode *old_dir, struct 
dentry *old_dentry,
 }
 EXPORT_SYMBOL_GPL(__fscrypt_prepare_rename);
 
-int __fscrypt_prepare_lookup(struct inode *dir, struct dentry *dentry,
-                            struct fscrypt_name *fname)
-{
-       int err = fscrypt_setup_filename(dir, &dentry->d_name, 1, fname);
-
-       if (err && err != -ENOENT)
-               return err;
-
-       fscrypt_prepare_lookup_dentry(dentry, fname->is_nokey_name);
-
-       return err;
-}
-EXPORT_SYMBOL_GPL(__fscrypt_prepare_lookup);
-
 /**
  * fscrypt_prepare_lookup_partial() - prepare lookup without filename setup
  * @dir: the encrypted directory being searched
diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h
index 68ca8706483a..4aaf847955c0 100644
--- a/include/linux/fscrypt.h
+++ b/include/linux/fscrypt.h
@@ -382,8 +382,6 @@ int __fscrypt_prepare_link(struct inode *inode, struct 
inode *dir,
 int __fscrypt_prepare_rename(struct inode *old_dir, struct dentry *old_dentry,
                             struct inode *new_dir, struct dentry *new_dentry,
                             unsigned int flags);
-int __fscrypt_prepare_lookup(struct inode *dir, struct dentry *dentry,
-                            struct fscrypt_name *fname);
 int fscrypt_prepare_lookup_partial(struct inode *dir, struct dentry *dentry);
 int __fscrypt_prepare_readdir(struct inode *dir);
 int __fscrypt_prepare_setattr(struct dentry *dentry, struct iattr *attr);
@@ -704,13 +702,6 @@ static inline int __fscrypt_prepare_rename(struct inode 
*old_dir,
        return -EOPNOTSUPP;
 }
 
-static inline int __fscrypt_prepare_lookup(struct inode *dir,
-                                          struct dentry *dentry,
-                                          struct fscrypt_name *fname)
-{
-       return -EOPNOTSUPP;
-}
-
 static inline int fscrypt_prepare_lookup_partial(struct inode *dir,
                                                 struct dentry *dentry)
 {
@@ -985,14 +976,22 @@ static inline int fscrypt_prepare_lookup(struct inode 
*dir,
                                         struct dentry *dentry,
                                         struct fscrypt_name *fname)
 {
-       if (IS_ENCRYPTED(dir))
-               return __fscrypt_prepare_lookup(dir, dentry, fname);
+       int err = 0;
+
+       if (IS_ENCRYPTED(dir)) {
+               err = fscrypt_setup_filename(dir, &dentry->d_name, 1, fname);
+               if (err && err != -ENOENT)
+                       return err;
+       } else {
+               memset(fname, 0, sizeof(*fname));
+               fname->usr_fname = &dentry->d_name;
+               fname->disk_name.name = (unsigned char *)dentry->d_name.name;
+               fname->disk_name.len = dentry->d_name.len;
+       }
 
-       memset(fname, 0, sizeof(*fname));
-       fname->usr_fname = &dentry->d_name;
-       fname->disk_name.name = (unsigned char *)dentry->d_name.name;
-       fname->disk_name.len = dentry->d_name.len;
-       return 0;
+       fscrypt_prepare_lookup_dentry(dentry, fname->is_nokey_name);
+
+       return err;
 }
 
 /**
-- 
2.43.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel