On 2024/6/6 17:52, Chao Yu wrote:
Since background GC is f2fs inner operation, so, let's use
sb_{start,end}_intwrite{_trylock,}() instead of
sb_{start,end}_write{_trylock,}() in gc_thread_func().
It may cause racing in between gc_thread and freeze_super(), result in
writeback of dirty page after ->freeze, so please ignore this patch.
- sb_wait_write(sb, SB_FREEZE_WRITE)
- sync_filesystem(sb)
- sb_start_intwrite_trylock
- f2fs_gc
: dirty pages
- sb_wait_write(sb, SB_FREEZE_FS)
Thanks,
Signed-off-by: Chao Yu <c...@kernel.org>
---
fs/f2fs/gc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index ef667fec9a12..004587ac5530 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -76,7 +76,7 @@ static int gc_thread_func(void *data)
f2fs_stop_checkpoint(sbi, false,
STOP_CP_REASON_FAULT_INJECT);
- if (!sb_start_write_trylock(sbi->sb)) {
+ if (!sb_start_intwrite_trylock(sbi->sb)) {
stat_other_skip_bggc_count(sbi);
continue;
}
@@ -163,7 +163,7 @@ static int gc_thread_func(void *data)
}
spin_unlock(&sbi->gc_remaining_trials_lock);
}
- sb_end_write(sbi->sb);
+ sb_end_intwrite(sbi->sb);
} while (!kthread_should_stop());
return 0;
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
