On 11/20/24 2:38 PM, Jaegeuk Kim wrote:
> On 11/20, Eric Sandeen wrote:
...
>> (Note that f2fs is the only filesystem that attempts to handle lazytime
>> within
>> the filesystem itself):
>>
>> [linux]# grep -r \"lazytime\" fs/*/
>> fs/f2fs/super.c: {Opt_lazytime, "lazytime"},
>> [linux]#
>>
>> I'm not entirely sure how to untangle all this, but regressions are not
>> acceptable,
>> so please revert my commit for now.
>
> Thanks for the explanation. At a glance, I thought it's caused that f2fs
> doesn't
> implement fs_context_operations. We'll take a look at how to support it.
(cc: list trimmed)
I had thought the conversion would resolve this too, but had not considered
direct
mount(2) calls passing the string in, which is something that probably needs to
be
supported even after the conversion, sadly.
As a reminder, this might be a start / sketch of how to convert to the new
mount API:
https://git.kernel.org/pub/scm/linux/kernel/git/sandeen/linux.git/log/?h=f2fs-mount-api
It's not entirely correct, but at least the first several patches are probably
the right
idea - getting sb / sbi out of the parsing path, and deferring
option-vs-disk-feature
checks until after the superblock is read, etc.
The final patch is probably not the way to go - it allocates an entire
f2fs_sb_info
in f2fs_init_fs_context - it probably makes more sense to create a new context
structure which holds only mount options, which is then transferred into the
sbi after option parsing during mount or remount.
I was doing these conversions as a side project, and given the f2fs conversion
complexity, I have yet to get to a series that I'm happy with. Perhaps expert
eyes can help!
Thanks,
-Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
