On Thu, May 22, 2025 at 7:06 PM Chao Yu <c...@kernel.org> wrote:
>
> On 5/23/25 02:26, Daeho Jeong wrote:
> > From: Daeho Jeong <daehoje...@google.com>
> >
> > Otherwise, it doesn't work with a crash.
> >
> > Signed-off-by: Daeho Jeong <daehoje...@google.com>
> > ---
> > v2: relocate the code
> > ---
> >  lib/libf2fs.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/lib/libf2fs.c b/lib/libf2fs.c
> > index d2579d7..148dc12 100644
> > --- a/lib/libf2fs.c
> > +++ b/lib/libf2fs.c
> > @@ -1347,6 +1347,11 @@ int f2fs_get_f2fs_info(void)
> >                       }
> >                       c.zone_blocks = c.devices[i].zone_blocks;
> >               }
> > +             if (c.zone_blocks < DEFAULT_BLOCKS_PER_SEGMENT) {
>
> If c.zone_blocks can not be aligned to DEFAULT_BLOCKS_PER_SEGMENT, do we need 
> to
> handle below code?

We need to make sure that c.zone_blocks is a multiple of
DEFAULT_BLOCKS_PER_SEGMENT, right?

>
>                 /*
>                  * Align sections to the device zone size and align F2FS zones
>                  * to the device zones. For F2FS_ZONED_HA model without the
>                  * BLKZONED feature set at format time, this is only an
>                  * optimization as sequential writes will not be enforced.
>                  */
>                 c.segs_per_sec = c.zone_blocks / DEFAULT_BLOCKS_PER_SEGMENT;
>
> Thanks,
>
> > +                     MSG(0, "\tError: zone size should not be less "
> > +                             "than segment size\n");
> > +                     return -1;
> > +             }
> >
> >               /*
> >                * Align sections to the device zone size and align F2FS zones
>


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to