syzbot report a f2fs bug as below:
CPU: 0 UID: 0 PID: 5840 Comm: syz-executor138 Not tainted
6.15.0-rc7-next-20250523-syzkaller #0 PREEMPT(full)
Call Trace:
<TASK>
dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
print_address_description mm/kasan/report.c:408 [inline]
print_report+0xd2/0x2b0 mm/kasan/report.c:521
kasan_report+0x118/0x150 mm/kasan/report.c:634
sanity_check_valid_blocks fs/f2fs/segment.h:385 [inline]
build_sit_entries+0x1b0c/0x1f80 fs/f2fs/segment.c:5060
f2fs_build_segment_manager+0x3112/0x49f0 fs/f2fs/segment.c:5707
f2fs_fill_super+0x45bc/0x6c80 fs/f2fs/super.c:4754
mount_bdev+0x211/0x2c0 fs/super.c:1736
legacy_get_tree+0xfd/0x1a0 fs/fs_context.c:666
vfs_get_tree+0x92/0x2b0 fs/super.c:1802
do_new_mount+0x24a/0xa40 fs/namespace.c:3869
do_mount fs/namespace.c:4206 [inline]
__do_sys_mount fs/namespace.c:4417 [inline]
__se_sys_mount+0x317/0x410 fs/namespace.c:4394
do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f
sanity_check_valid_blocks() should be called after set_ckpt_valid_blocks()
in the loop, otherwise, @segno passed to sanity_check_valid_blocks() will
become invalid, fix it.
Fixes: 313d10d79a82 ("f2fs: add ckpt_valid_blocks to the section entry")
Reported-by: syzbot+1fa48dc6faf1ff972...@syzkaller.appspotmail.com
Closes:
https://lore.kernel.org/linux-f2fs-devel/68345c8d.a70a0220.253bc2.0097....@google.com
Cc: yohan.joung <yohan.jo...@sk.com>
Signed-off-by: Chao Yu <c...@kernel.org>
---
Change v1:
- merge this into original patch is fine to me as well.
fs/f2fs/segment.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 5ff0111ed974..b77b5de71a48 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -5054,10 +5054,10 @@ static int build_sit_entries(struct f2fs_sb_info *sbi)
if (__is_large_section(sbi)) {
unsigned int segno;
- for (segno = 0; segno < MAIN_SEGS(sbi); segno +=
SEGS_PER_SEC(sbi))
+ for (segno = 0; segno < MAIN_SEGS(sbi); segno +=
SEGS_PER_SEC(sbi)) {
set_ckpt_valid_blocks(sbi, segno);
-
- sanity_check_valid_blocks(sbi, segno);
+ sanity_check_valid_blocks(sbi, segno);
+ }
}
if (err)
--
2.49.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
