All callers now have a folio so pass it in. Signed-off-by: Matthew Wilcox (Oracle) <wi...@infradead.org> --- fs/f2fs/inode.c | 2 +- fs/f2fs/node.c | 12 ++++++------ fs/f2fs/node.h | 2 +- fs/f2fs/segment.c | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 9b71e3e4f635..68510c2d90a9 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -482,7 +482,7 @@ static int do_read_inode(struct inode *inode) __recover_inline_status(inode, node_folio); /* try to recover cold bit for non-dir inode */ - if (!S_ISDIR(inode->i_mode) && !is_cold_node(&node_folio->page)) { + if (!S_ISDIR(inode->i_mode) && !is_cold_node(node_folio)) { f2fs_folio_wait_writeback(node_folio, NODE, true, true); set_cold_node(node_folio, false); folio_mark_dirty(node_folio); diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index b55827d687e2..d406342714f7 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -313,7 +313,7 @@ static unsigned int __gang_lookup_nat_set(struct f2fs_nm_info *nm_i, bool f2fs_in_warm_node_list(struct f2fs_sb_info *sbi, struct folio *folio) { return is_node_folio(folio) && IS_DNODE(&folio->page) && - is_cold_node(&folio->page); + is_cold_node(folio); } void f2fs_init_fsync_node_info(struct f2fs_sb_info *sbi) @@ -1631,7 +1631,7 @@ static struct folio *last_fsync_dnode(struct f2fs_sb_info *sbi, nid_t ino) return ERR_PTR(-EIO); } - if (!IS_DNODE(&folio->page) || !is_cold_node(&folio->page)) + if (!IS_DNODE(&folio->page) || !is_cold_node(folio)) continue; if (ino_of_node(folio) != ino) continue; @@ -1702,7 +1702,7 @@ static bool __write_node_folio(struct folio *folio, bool atomic, bool *submitted if (!is_sbi_flag_set(sbi, SBI_CP_DISABLED) && wbc->sync_mode == WB_SYNC_NONE && - IS_DNODE(&folio->page) && is_cold_node(&folio->page)) + IS_DNODE(&folio->page) && is_cold_node(folio)) goto redirty_out; /* get old block addr of this node page */ @@ -1840,7 +1840,7 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode, goto out; } - if (!IS_DNODE(&folio->page) || !is_cold_node(&folio->page)) + if (!IS_DNODE(&folio->page) || !is_cold_node(folio)) continue; if (ino_of_node(folio) != ino) continue; @@ -2043,10 +2043,10 @@ int f2fs_sync_node_pages(struct f2fs_sb_info *sbi, if (step == 0 && IS_DNODE(&folio->page)) continue; if (step == 1 && (!IS_DNODE(&folio->page) || - is_cold_node(&folio->page))) + is_cold_node(folio))) continue; if (step == 2 && (!IS_DNODE(&folio->page) || - !is_cold_node(&folio->page))) + !is_cold_node(folio))) continue; lock_node: if (wbc->sync_mode == WB_SYNC_ALL) diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h index aea801c58097..a03e30a1b8c2 100644 --- a/fs/f2fs/node.h +++ b/fs/f2fs/node.h @@ -403,7 +403,7 @@ static inline int is_node(const struct page *page, int type) return le32_to_cpu(rn->footer.flag) & BIT(type); } -#define is_cold_node(page) is_node(page, COLD_BIT_SHIFT) +#define is_cold_node(folio) is_node(&folio->page, COLD_BIT_SHIFT) #define is_fsync_dnode(folio) is_node(&folio->page, FSYNC_BIT_SHIFT) #define is_dent_dnode(folio) is_node(&folio->page, DENT_BIT_SHIFT) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 533b4295e4d6..cd49015a905a 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -3620,7 +3620,7 @@ static int __get_segment_type_4(struct f2fs_io_info *fio) else return CURSEG_COLD_DATA; } else { - if (IS_DNODE(fio->page) && is_cold_node(fio->page)) + if (IS_DNODE(fio->page) && is_cold_node(fio->folio)) return CURSEG_WARM_NODE; else return CURSEG_COLD_NODE; @@ -3678,7 +3678,7 @@ static int __get_segment_type_6(struct f2fs_io_info *fio) inode->i_write_hint); } else { if (IS_DNODE(fio->page)) - return is_cold_node(fio->page) ? CURSEG_WARM_NODE : + return is_cold_node(fio->folio) ? CURSEG_WARM_NODE : CURSEG_HOT_NODE; return CURSEG_COLD_NODE; } -- 2.47.2 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel