On 07/10, Matthew Wilcox wrote:
> On Thu, Jul 10, 2025 at 03:17:28PM +0800, kernel test robot wrote:
> > >> fs/f2fs/data.c:58:56: error: passing 'const struct folio *' to parameter
> > >> of type 'struct folio *' discards qualifiers
> > >> [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> > 58 | return
> > folio_test_f2fs_gcing(fscrypt_pagecache_folio(folio));
> > |
> > ^~~~~
> > include/linux/fscrypt.h:527:67: note: passing argument to parameter
> > 'bounce_folio' here
> > 527 | static inline struct folio *fscrypt_pagecache_folio(struct folio
> > *bounce_folio)
>
> Ah; I changed only one of the definitions of fscrypt_pagecache_folio.
>
> Jaegeuk, can you fold in this fix?
Will this break ext4?
In ext4,
struct folio *folio = fi.folio;
...
if (fscrypt_is_bounce_folio(folio)) {
io_folio = folio;
folio = fscrypt_pagecache_folio(folio);
}
>
> diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h
> index b334c0538864..8d9127a0fdb3 100644
> --- a/include/linux/fscrypt.h
> +++ b/include/linux/fscrypt.h
> @@ -524,7 +524,8 @@ static inline bool fscrypt_is_bounce_folio(const struct
> folio *folio)
> return false;
> }
>
> -static inline struct folio *fscrypt_pagecache_folio(struct folio
> *bounce_folio)
> +static inline
> +struct folio *fscrypt_pagecache_folio(const struct folio *bounce_folio)
> {
> WARN_ON_ONCE(1);
> return ERR_PTR(-EINVAL);
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
