On 11/1/25 19:44, Zorro Lang wrote: > On Mon, Oct 20, 2025 at 10:31:08AM +0800, Chao Yu wrote: >> f2fs/022 will report failure as below: >> >> f2fs/022 - output mismatch (see >> /share/git/fstests/results//f2fs/022.out.bad) >> --- tests/f2fs/022.out 2025-10-20 10:18:47.075968669 +0800 >> +++ /share/git/fstests/results//f2fs/022.out.bad 2025-10-20 >> 10:25:20.000000000 +0800 >> @@ -1,2 +1,5 @@ >> QA output created by 022 >> +wrote 8388608/8388608 bytes at offset 0 >> +8 MiB, 2048 ops; 0.0018 sec (4.300 GiB/sec and 1127132.6362 ops/sec) >> +fallocate: Operation not supported >> Silence is golden >> ... >> (Run 'diff -u /share/git/fstests/tests/f2fs/022.out >> /share/git/fstests/results//f2fs/022.out.bad' to see the entire diff) >> >> HINT: You _MAY_ be missing kernel fix: >> xxxxxxxxxxxx f2fs: fix to do sanity check on node footer for non inode >> dnode >> >> Fix this testcase as below: >> >> - fix a typo "$SCARTCH_MNT" >> - fix to update output to "fallocate: Structure needs cleaning" >> - relocate output of "$XFS_IO_PROG $foo_path -c "pwrite 0 8M"" to >> $seqres.full >> >> Cc: Jaegeuk Kim <[email protected]> >> Signed-off-by: Chao Yu <[email protected]> >> --- >> tests/f2fs/022 | 8 +++----- >> tests/f2fs/022.out | 2 +- >> 2 files changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/tests/f2fs/022 b/tests/f2fs/022 >> index f6d77c96..728ef4e8 100755 >> --- a/tests/f2fs/022 >> +++ b/tests/f2fs/022 >> @@ -24,15 +24,15 @@ _require_inject_f2fs_command node i_nid >> # remove all mkfs options to avoid layout change of on-disk inode >> export MKFS_OPTIONS="" >> >> -foo_path=$SCARTCH_MNT/foo >> -bar_path=$SCARTCH_MNT/bar >> +foo_path=$SCRATCH_MNT/foo >> +bar_path=$SCRATCH_MNT/bar > > Hahaha, I took long time to find out what these 2 lines try to change:) Thanks > for fixing this.
Haha, Seems I rebased v2 to a problematic codebase when I sync-up code from different git repo. It took me some time to find the root cause of 022 failure. :/ Anyway, thanks for the review. :) Thanks, > > Reviewed-by: Zorro Lang <[email protected]> > >> >> _scratch_mkfs >> $seqres.full >> _scratch_mount >> >> touch $foo_path >> touch $bar_path >> -$XFS_IO_PROG $foo_path -c "pwrite 0 8M" >> +$XFS_IO_PROG $foo_path -c "pwrite 0 8M" >> $seqres.full >> sync >> foo_ino=`stat -c '%i' $foo_path` >> bar_ino=`stat -c '%i' $bar_path` >> @@ -48,7 +48,5 @@ _scratch_mount >> $XFS_IO_PROG $foo_path -c "fpunch 6984k 4k" >> _scratch_unmount >> >> -echo "Silence is golden" >> - >> status=0 >> exit >> diff --git a/tests/f2fs/022.out b/tests/f2fs/022.out >> index 394c6a7c..5307e3d7 100644 >> --- a/tests/f2fs/022.out >> +++ b/tests/f2fs/022.out >> @@ -1,2 +1,2 @@ >> QA output created by 022 >> -Silence is golden >> +fallocate: Structure needs cleaning >> -- >> 2.49.0 >> > _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
