On Tue, Jan 27, 2026 at 07:28:17PM -0800, Eric Biggers wrote:
> > - * a race condition where the file is being read concurrently with
> > - * FS_IOC_ENABLE_VERITY completing. (S_VERITY is set before the verity
> > info.)
> > + * This checks whether the inode's verity info has been set, and reads need
> > + * to verify the verity information.
>
> Nit: the point is to verify the file's data, not to verify "the verity
> information".
Ok.
> > -static inline bool fsverity_active(const struct inode *inode)
> > +static __always_inline bool fsverity_active(const struct inode *inode)
> > +{
> > + if (IS_ENABLED(CONFIG_FS_VERITY) && IS_VERITY(inode)) {
> > + /*
> > + * This pairs with the try_cmpxchg in set_mask_bits()
> > + * used to set the S_VERITY bit in i_flags.
> > + */
> > + smp_mb();
> > + return true;
> > + }
> > +
> > + return false;
> > +}
>
> Is there a reason for this function in particular to be __always_inline?
> fsverity_get_info() is just inline.
Without the __always_inline some gcc versions on sparc fail to inline it,
and cause a link failure due to a reference to fsverity_readahead in
f2fs_mpage_readpages for non-verity builds. (reported by the buildbot)
>
> - Eric
---end quoted text---
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
