On Sun, Feb 15, 2026 at 03:38:20AM +0000, Matthew Wilcox wrote:
> On Sat, Feb 14, 2026 at 01:50:08PM -0800, Eric Biggers wrote:
> > On Sat, Feb 14, 2026 at 01:18:29PM -0800, Eric Biggers wrote:
> > > +++ b/fs/f2fs/compress.c
> > > @@ -1811,15 +1811,19 @@ static void f2fs_verify_cluster(struct
> > > work_struct *work)
> > > int i;
> > >
> > > /* Verify, update, and unlock the decompressed pages. */
> > > for (i = 0; i < dic->cluster_size; i++) {
> > > struct page *rpage = dic->rpages[i];
> > > + struct folio *rfolio;
> > > + size_t offset;
> > >
> > > if (!rpage)
> > > continue;
> > > + rfolio = page_folio(rpage);
> > > + offset = folio_page_idx(rfolio, rpage) * PAGE_SIZE;
> > >
> > > - if (fsverity_verify_page(dic->vi, rpage))
> > > + if (fsverity_verify_blocks(dic->vi, rfolio, PAGE_SIZE, offset))
> > > SetPageUptodate(rpage);
>
> Yeah, no.
>
> if (fsverity_verify_blocks(dic->vi, rfolio,
> folio_size(rfolio), 0));
> folio_mark_uptodate(rfolio);
>
> > > else
> > > ClearPageUptodate(rpage);
>
> This never needed to be here. The folio must already be !uptodate.
> Just delete these two lines.
>
> > > unlock_page(rpage);
>
> folio_unlock(rfolio);
Sure. This kind of scope creep is why I wanted to just do the
straightforward conversion for now.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
