On Tue, May 12, 2026 at 09:43:08AM -0700, Darrick J. Wong wrote:
> > diff --git a/mm/swapfile.c b/mm/swapfile.c
> > index 651c1b59ff9f..1b7fc03612f4 100644
> > --- a/mm/swapfile.c
> > +++ b/mm/swapfile.c
> > @@ -2783,25 +2783,24 @@ static int setup_swap_extents(struct
> > swap_info_struct *sis,
> > {
> > struct address_space *mapping = swap_file->f_mapping;
> > struct inode *inode = mapping->host;
> > - int ret;
> > + int ret, error = 0;
>
> /me wonders why not reuse ret instead of declaring a new variable?
Because when I wrote this, the setup methods could still return a
positive number of extents value that must not be clobbered. Since
then I added patches before this that removed that, so we can use
the same ret variable.
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel