Hi Michael,

Michael Tautschnig wrote:
Thanks a lot for debugging this issue and providing a patch.  Could you please
attach a config where you experienced these issues? I do acknowledge the fact

it was a simple config like:

disk_config sda preserve_reinstall:1,2,3

primary         /var    100     xfs     defaults
primary         swap    256     swap    sw
primary         /scratch        100-    xfs     defaults


that there is a bug, but I believe the bug should be fixed in some other way;
did you also test your patched version? I'm not sure whether parted will

of course I did.

actually accept linux-swap(v1) as specification. I think we should be rewriting
linux-swap(v1) to swap or linux-swap in Volumes.pm.

parted does seem to use linux-swap(v1), if I do "parted -s /dev/sda print":

Model: ATA QEMU HARDDISK (scsi)
Disk /dev/sda: 10.7GB
Sector size (logical/physical): 512B/512B
Partition Table: msdos

Number  Start   End     Size    Type     File system     Flags
 1      32.3kB  98.7MB  98.7MB  primary  xfs
 2      98.7MB  362MB   263MB   primary  linux-swap(v1)
 3      362MB   10.7GB  10.4GB  primary  xfs

Cheers,

  Peter

Reply via email to