Hi Al, That's a good idea. Will do. - Peter - On Tue, 24 Apr 2001, Alexander Viro wrote: > > > On Tue, 24 Apr 2001, Peter J. Braam wrote: > > > Hi, > > > > I thought that Andrew's suggestion below really warrants review by the list. > > > > This is regarding a new super method to give the fs a notification when a > > block is written in order to support journal file systems. > > [snip] > > I would rather see it done as an explicit argument passed to library > function. Notice that ->get_block() got that treatment - it's not > a method anymore. If you have a code that would be (modulo using > different callbacks) useful for many filesystems - by all means, make > it a helper function and pass the callback as its argument. It's > cleaner than bloating object interfaces with methods that are never > going to be called by anything other than methods of the same object. > > Al > > -- - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED]
