>>>>> " " == Alexander Viro <[EMAIL PROTECTED]> writes:
> Trond, could you review the patch below? I believe that it's
> OK
> wrt races around iget(), but I'd appreciate if you take a look
> at it.
> + NFS_CACHEINV(inode);
> + /* Why so? Because we want revalidate for devices/FIFOs, and
> + * that's precisely what we have in nfs_file_inode_operations.
> + */
<snip>
> +
> + nfs_refresh_inode(inode, fattr);
Al,
As I said, the patch looks good, and the races are gone. The only
question I have is about the above section in nfs_fhget(). AFAICS the
NFS_CACHEINV() you've inserted here will get clobbered by the
nfs_refresh_inode() below it.
I'm not sure I really understand the need for a NFS_CACHEINV
though. Why do you want to revalidate the attribute cache immediately
after having initialized the inode? After all, under NFS, lookup is
guaranteed to return the correct attributes...
Cheers,
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]