On Thu, Feb 03, 2005 at 08:56:50AM -0800, Badari Pulavarty wrote: > On Thu, 2005-02-03 at 09:00, Sonny Rao wrote: > > > > > Well it seems to work, here's my (rather ugly) patch. > > I'm doing some performance comparisons now. > > > > Sonny > > Interesting.. Why did you create a nobh_prepare_write() ? > mpage_writepages() can handle pages with buffer heads > attached.
IIRC, block_prepare_write will attach buffer_heads for you, which I'm explicitly trying to avoid. > And also, are you sure you don't need to journal start/stop > in writepages() ? Heh, I'm not sure, I don't understand the semantics of those calls well enough to say with certainty. My guess is no, because the blocks on disk were already allocated beforehand. Maybe it could be a problem if there could be a truncate in progress elsewhere, but I don't think so since the inode is locked. Sonny - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
