Werner Almesberger <[EMAIL PROTECTED]> writes: > In the case of non-VFAT, there's also the issue that pretending to > support atime causes atime to jump back and forth unpredictably, > depending on when the inode is evicted from memory. (And the low > adate resolution means that even VFAT will have a similar problem.)
Yes. We would need to add something to timespec_trunc() for it. And unfortunately de->time too. > But I guess if nobody complained in the last twelve or so years, > we're in no hurry to fix that ;-) Thanks. :) > @@ -1059,6 +1131,8 @@ int fat_fill_super(struct super_block *s > memset(sbi, 0, sizeof(struct msdos_sb_info)); > > sb->s_flags |= MS_NODIRATIME; > + if (!isvfat) > + sb->s_flags |= MS_NOATIME; > sb->s_magic = MSDOS_SUPER_MAGIC; > sb->s_op = &fat_sops; > sb->s_export_op = &fat_export_ops; Looks good to me. But, I don't know whether actually DOS updates ->adate or not. It would depend on it. Thanks. -- OGAWA Hirofumi <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
