Dave Kleikamp <[EMAIL PROTECTED]> wrote:
>
> > +   err = ext2_init_security(inode,dir);
> 
> Won't this be unresolved if CONFIG_EXT2_FS_SECURITY is unset?
> xattr_security.c won't be compiled at all.  The ext3 patch has the same
> problem.

Yeah.  I think I kicked this into shape in rc2-mm2:

--- 25/fs/ext3/xattr.h~ext3-enable-atomic-inode-security-labeling-fix   
2005-07-12 05:02:43.000000000 -0600
+++ 25-akpm/fs/ext3/xattr.h     2005-07-12 05:18:06.000000000 -0600
@@ -67,7 +67,6 @@ extern struct xattr_handler ext3_xattr_s
 
 extern ssize_t ext3_listxattr(struct dentry *, char *, size_t);
 
-extern int ext3_init_security(handle_t *handle, struct inode *inode, struct 
inode *dir);
 extern int ext3_xattr_get(struct inode *, int, const char *, void *, size_t);
 extern int ext3_xattr_list(struct inode *, char *, size_t);
 extern int ext3_xattr_set(struct inode *, int, const char *, const void *, 
size_t, int);
@@ -134,3 +133,14 @@ exit_ext3_xattr(void)
 #define ext3_xattr_handlers    NULL
 
 # endif  /* CONFIG_EXT3_FS_XATTR */
+
+#ifdef CONFIG_EXT3_FS_SECURITY
+extern int ext3_init_security(handle_t *handle, struct inode *inode,
+                               struct inode *dir);
+#else
+static inline int ext3_init_security(handle_t *handle, struct inode *inode,
+                               struct inode *dir)
+{
+       return 0;
+}
+#endif
_

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to