Hi, On Mon, 2005-08-29 at 20:41, Andreas Dilger wrote: > On Aug 29, 2005 18:40 +0100, Matthew Wilcox wrote: > > journal_commit_transaction() is still 650+ lines long and contains 16 > > local variables. By moving phase 3 into its own function, we reduce > > its length by 150+ lines and reduce it to 5 local variables.
Thanks. > The one comment I have here is that in the past GCC has been bad at > allocating local variables on the stack, and would reserve the sum > of all local variables instead of the union. This would unnecessarily > bloat code that had a lot of local variables defined in only a subset > of the function. Could you verify with checkstack that this doesn't hit > here? Well, I remember one gcc problem where a gcc errata --- not even a major version change --- suddenly started reserving massively more space not just for the function itself, but for everything inlined into it too. It seems to be highly gcc version-specific, and we still support some rather old gccs. --Stephen - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
