On Mon, Apr 02, 2007 at 05:00:50PM -0700, Badari Pulavarty wrote:
> On Mon, 2007-04-02 at 14:09 +0200, Nick Piggin wrote:
> > Updated aops patchset against 2.6.21-rc5.
> >
> > http://www.kernel.org/pub/linux/kernel/people/npiggin/patches/new-aops/
> >
> > Files/dirs are 2.6.21-rc5-new-aops*
>
> One more cleanup. "index" is unused.
Indeed. I wonder why gcc (at least the 4.0 I'm using) doesn't warn if a
local, non volatile is only ever assigned to?
> BTW, I will take a shot at ext4 tomorrow.
Thanks, so long as you think ext3 is looking OK?
BTW. is it a known issue that ext3 fails fsx-linux? (I tried 2.6.21-rc3
IIRC, and ordered and writeback both eventually failed I think). ext2
does not.
> (If you want me to roll all my fixes and send them to you,u,
>
> 5.)
>
>
> 1 c link
>
> 5.orig?
>
>
> h2
> (
^^^ I hope that wasn't due to your running the new aops patches! ;)
>
> and send them to you,
> let me know).
I have merged them all up, so it should be fine. Thanks very much.
Nick
>
> Thanks,
> Badari
>
> ---
> mm/filemap.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: linux-2.6.21-rc5/mm/filemap.c
> ===================================================================
> --- linux-2.6.21-rc5.orig/mm/filemap.c 2007-04-02 16:23:48.000000000
> -0700
> +++ linux-2.6.21-rc5/mm/filemap.c 2007-04-02 16:53:13.000000000 -0700
> @@ -2383,14 +2383,12 @@ static ssize_t generic_perform_write(str
>
> do {
> struct page *page;
> - pgoff_t index; /* Pagecache index for current page */
> unsigned long offset; /* Offset into pagecache page */
> unsigned long bytes; /* Bytes to write to page */
> size_t copied; /* Bytes copied from user */
> void *fsdata;
>
> offset = (pos & (PAGE_CACHE_SIZE - 1));
> - index = pos >> PAGE_CACHE_SHIFT;
> bytes = min_t(unsigned long, PAGE_CACHE_SIZE - offset,
> iov_iter_count(i));
>
>
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
