On Mon, Jan 14, 2008 at 04:15:05PM +0300, Q (Igor Mammedov) wrote:
> > +   dput(nd->dentry);
> > +   nd->dentry = dget(dentry);
> > +   if (d_mountpoint(nd->dentry))
> > +           goto out_follow;
> > 
> > A link should never be a mountpoint.
> 
> why link? after patch 5 are applied DFS junction point becomes directory
> instead of link. That is what has been done in NFS code.

True, this is the ->follow_link on directory hack.

> Actually I copy & pasted it from NFS code ...
> fs/nfs/namespace.c:nfs_follow_mountpoint
> 
> I've tried to do submount/referral machinery in NFS code way.

Okay, and that came from afs.  I really think we should take large
parts of this back into the VFS because it's just to fragile to
be duplicated in various filesystems.  Probably not a blocker for
your patch but I'll keep an eye on consolidating this back into
the core.

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to