In message <[EMAIL PROTECTED]>, Alexander
Viro writes:
>
>
> On Wed, 5 Apr 2000, Erez Zadok wrote:
>
> > - if (block_start >= to)
> > - break;
> > bh->b_end_io = end_buffer_io_sync;
> > if (!buffer_mapped(bh)) {
> > err = get_block(inode, block, bh, 1);
>
> And there you go: bloody thing bumps the size of every file to 4k
> boundary. Which is _not_ going to make fsck[1] happy, since ->i_size is
> not consistent with the block pointers in inode. get_block() has side
> effects, damnit.
>
> [1] (8), that is.
We were not sure our patch was right, and now we are certain it isn't.
Thanks to you and Erik for pointing out these problems. Maybe all that's
needed is more documentation in the code?
Either way, we'll have to change our stacking code so that it'll probably do
a readpage after a wait_on_page that isn't uptodate.
Thanks,
Erez.
