On Tuesday, December 22, 2015 at 03:14:10 PM, Linus Walleij wrote: > As we want gpio_chip .get() calls to be able to return negative > error codes and propagate to drivers, we need to go over all > drivers and make sure their return values are clamped to [0,1]. > We do this by using the ret = !!(val) design pattern. > > Also start to propagate the error code here as the end of the > series fixes this to work for all drivers. > > Cc: Nicholas Krause <xerofo...@gmail.com> > Cc: Marek Vasut <ma...@denx.de> > Cc: Semen Protsenko <semen.protse...@globallogic.com> > Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
I see nothing obviously wrong with the patch: Reviewed-by: Marek Vasut <ma...@denx.de> > --- > drivers/gpio/gpio-max732x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-max732x.c b/drivers/gpio/gpio-max732x.c > index a1094984b666..880ce94e6077 100644 > --- a/drivers/gpio/gpio-max732x.c > +++ b/drivers/gpio/gpio-max732x.c > @@ -207,9 +207,9 @@ static int max732x_gpio_get_value(struct gpio_chip *gc, > unsigned off) > > ret = max732x_readb(chip, is_group_a(chip, off), ®_val); > if (ret < 0) > - return 0; > + return ret; > > - return reg_val & (1u << (off & 0x7)); > + return !!(reg_val & (1u << (off & 0x7))); > } > > static void max732x_gpio_set_mask(struct gpio_chip *gc, unsigned off, int > mask, Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
