On Fri, Aug 16, 2013 at 8:20 PM, Mark Brown <[email protected]> wrote:
>> This is definately to be fixed since it's using a new core MFD >> driver. > > It's common to have inline wrappers for the regmap ops which take the > device specific struct and fish the regmap pointer out of it. I had no clue ... hm this is another side effect of not getting the whole patch set I guess. >> Please use an irqdomain with the handling in the MFD core >> instead so the driver get a translated IRQ base per AS3722 IRQ passed, >> and get rid of this clunkiness. > >> For example see how we're handling this in ab8500-core.c >> and abx500-pinctrl.c > > This is actually doing the same thing as the ab8500 doing there - all > regmap_irq_get_virq() is doing is calling irq_create_mapping() on the > irqdomain to translate a hwirq into a virq. Hmmm I've been irritated about the "v" in "virq" because these interrupt numbers are and have always been Linux interrupt numbers, that they sometimes, on some systems, for the low IRQs, correspond to the hardware IRQ numbers is pure pattern matching and luck. They are no more "virtual" than any other IRQ numbers in the kernel. They are all "virtual" in a sense. Well nevermind that, it's probably just another try at tilting windmills to get it changed anyway. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
