On Fri, Sep 13, 2013 at 11:41 PM, Graeme Smecher <[email protected]> wrote:
> The pca957x driver supports a handful of I2C GPIO expanders from NXP, Maxim, > and TI. For the PCA9574 and PCA9575 devices only, the driver resets the GPIO > level and direction in the pca957x_probe function. This seems like the wrong > thing to do, since it can cause hardware bit twiddles during warm reboots when > the chip state and reset values don't match. > > This kind of initialization is best left upstream (in a bootloader) or > downstream (in userspace). It's also an inconsistency across devices supported > by this driver. > > This patch is NOT boot-tested: the SoC I'm using is stuck on 2.6.37, and the > patch doesn't apply trivially. > > Signed-off-by: Graeme Smecher <[email protected]> > Acked-by: Haojian Zhuang <[email protected]> Looks like you're deleting code from Gregory CLEMENT, Gregory what do you say about this? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
