On Tue, Sep 24, 2013 at 5:24 AM, Linus Walleij <[email protected]> wrote: > The SA1100 was implementing its own variants of gpio_get_value() > and gpio_set_value() and only selectively falling back to > gpiolib for extended (EGPIO) handling. However the driver in > gpio/gpio-sa1100.c already handles the same functionality for > these lines, yet remain unused. > > The only upside would be things like a timing-critical hotpath > on bit-banged GPIO, but that kind of things does not seem to > happen on these GPIOs, so it is not worth having the extra > complexity. > > Tested with some buttons on the Compaq iPAQ H3630. > > Cc: Russell King <[email protected]> > Cc: Kristoffer Ericson <[email protected]> > Signed-off-by: Linus Walleij <[email protected]> > --- > ChangeLog v1->v2: > - #include <linux/io.h> instead of <asm/io.h>.
Looks like this hit -next and it produces the following with simpad_defconfig: ../../arch/arm/include/asm/irq.h:9:0: warning: "NR_IRQS" redefined [enabled by default] #define NR_IRQS NR_IRQS_LEGACY ^ In file included from ../../arch/arm/mach-sa1100/simpad.c:29:0: ../../arch/arm/mach-sa1100/include/mach/irqs.h:87:0: note: this is the location of the previous definition #define NR_IRQS (IRQ_BOARD_START + NR_IRQS_LOCOMO) http://arm-soc.lixom.net/buildlogs/next-thierry/next-20131023/buildall.arm.simpad_defconfig.log.passed -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
