On Fri, Oct 25, 2013 at 12:24 PM, Darren Hart <[email protected]> wrote:
> On Fri, 2013-10-25 at 11:34 +0200, Linus Walleij wrote:
> Minnow doesn't currently have a CONFIG_ upstream which can be used to
> force this selection.
Well it wouldn't help with randconfig or allyesconfig anyway.
>> Is there some default y we can add so this gets compiled for this
>> entire board, or shall I set:
>>
>> depends on PCH_GBE
>> default y
>>
>> On the GPIO_LYNXPOINT or GPIO_PCH driver?
>
> Why would GPIO_PCH depend on PCH_GBE? The inverse is certainly true for
> MinnowBoard.
OK this was the wrong idea.
> I had some MinnowBoard Kconfig bits in my early drivers, but they
> included things like CONFIG_MINNOWBOARD which is not upstream (rightly
> so) but it means I don't have a way to conditionally make PCH_GBE
> dependent on GPIO_PCH and GPIOLIB.
>
> I wouldn't object to adding a dependency to GPIO_PCH and GPIOLIB
> unconditionally for PCH_GBE as GPIO_PCH is the same chip... but I don't
> know if David Miller would be amenable to that.
Well we should probably just stick a dependency to GPIOLIB in there.
- It #includes <linux/gpio.h>
- It uses gpiolib functions to do something vital
It was just happy that dummy versions were slotted in until now.
I'll post the following:
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/etherne
index a588ffde9700..f2528262aba7 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
@@ -4,7 +4,7 @@
config PCH_GBE
tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
- depends on PCI && (X86 || COMPILE_TEST)
+ depends on PCI && GPIOLIB && (X86 || COMPILE_TEST)
select MII
select PTP_1588_CLOCK_PCH
---help---
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
