On Wed, Oct 23, 2013 at 8:36 AM, Haojian Zhuang <[email protected]> wrote:
> gpio-ranges property could binds gpio to pinctrl. But there may be some > gpios without pinctrl operation. So check whether gpio-ranges property > exists in device node first. > > Signed-off-by: Haojian Zhuang <[email protected]> OK... > + /* Hook the request()/free() for pinctrl operation */ > + if (of_get_property(dev->of_node, "gpio-ranges", NULL)) { > + chip->gc.request = pl061_gpio_request; > + chip->gc.free = pl061_gpio_free; > + } This is quite hard for those not using pinctrl to understand, maybe someone wants to use the request/free callbacks for something else in the future. Can't you: - Add a variable bool uses_pinctrl to struct pl061_gpio - Use the bool check: if (of_property_read_bool(np, "gpio-ranges")) chip->uses_pinctrl = true; - Alter the code in pl061_gpio_request() to do like this: if (chip->uses_pinctrl) pinctrl_request_gpio() And the same for pl061_gpio_free(). Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
