Hi Linus,
On Thu, Jan 23, 2014 at 09:46:42AM +0100, Linus Walleij wrote:
> On Thu, Jan 23, 2014 at 7:50 AM, Baruch Siach <[email protected]> wrote:
> > In xtensa coprocessors may exist without coprocessor context, i.e. they
> > cannot
> > be disabled/enabled. In this case the RSR_CPENABLE/WSR_CPENABLE are
> > undefined,
> > thus breaking the build. Fix the build by adding dummy versions of
> > enable_cp/disable_cp in this case.
> >
> > Reported-by: Fengguang Wu <[email protected]>
> > Signed-off-by: Baruch Siach <[email protected]>
>
> Patch applied for fixes, but I really don't like this compile-time
> thing. It'd be better if your Xtensa code would adjust to different
> hardware at runtime rather than compile time. This is the overall
> kernel design pattern these days AFICT.
We are talking about Xtensa here, not ARM. Different Xtensa variants are
binary incompatible from each other is some very fundamental ways. In most
cases you even need a different toolchain for each variant. Given that, I'm
not sure that runtime hardware check is worth it, or even possible is some
cases.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
