Thank you Aaron, So I will continue using this encoding way for next supported chipsets.
-- Vincent. On Thu, Feb 06, 2014 at 09:55:54AM -0600, Aaron Sierra wrote: > ----- Original Message ----- > > From: "Vincent Donnefort" <[email protected]> > > Sent: Thursday, February 6, 2014 3:57:44 AM > > > > Hi, > > > > I'm working on adding Avoton support for ich_gpio. I noticed that > > GPIOs compatibility IDs defined into linux/drivers/mfd/lpc_ich.h > > aren't arbitrary but I can't find any trace of it into ICH10 and > > Avoton datasheet. How can I defined the right one? > > Vincent, > As far as I can tell, I am responsible for introducing the values > assigned to the .gpio_version member of the lpc_ich_info structure. > > I have to guess that my original intention was to encode the ICH > version, a version quirk identifier (see V10CONS and V10CORP, and > whether or not GPIO was supported into those values. > > There is no reason for these values to be encoded the way that they > are based on the current form of the driver. They are effectively > arbitrary. It would almost certainly be better if these were > defined as an enum instead of individual #defines. > > > > > Thanks, > > -- > > Vincent Donnefort > > > > -Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
