Hi Geert, Thank you for the patch.
On Thursday 27 March 2014 21:47:38 Geert Uytterhoeven wrote: > From: Geert Uytterhoeven <[email protected]> > > This is just enough to automatically enable the functional clock, if > present. Clock management during suspend/resume is still to be added. > > Signed-off-by: Geert Uytterhoeven <[email protected]> > Cc: Linus Walleij <[email protected]> > Cc: Laurent Pinchart <[email protected]> > Cc: [email protected] > --- > drivers/gpio/gpio-rcar.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c > index 03c91482432c..c6995f6c3c40 100644 > --- a/drivers/gpio/gpio-rcar.c > +++ b/drivers/gpio/gpio-rcar.c > @@ -26,6 +26,7 @@ > #include <linux/pinctrl/consumer.h> > #include <linux/platform_data/gpio-rcar.h> > #include <linux/platform_device.h> > +#include <linux/pm_runtime.h> > #include <linux/spinlock.h> > #include <linux/slab.h> > > @@ -377,6 +378,9 @@ static int gpio_rcar_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, p); > > + pm_runtime_enable(dev); > + pm_runtime_get_sync(dev); > + > io = platform_get_resource(pdev, IORESOURCE_MEM, 0); > irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > @@ -460,6 +464,8 @@ static int gpio_rcar_probe(struct platform_device *pdev) > err1: > irq_domain_remove(p->irq_domain); > err0: > + pm_runtime_put_sync(dev); Do we really need the sync version, isn't pm_runtime_put() enough ? > + pm_runtime_disable(dev); > return ret; > } > > @@ -473,6 +479,8 @@ static int gpio_rcar_remove(struct platform_device > *pdev) return ret; > > irq_domain_remove(p->irq_domain); > + pm_runtime_put_sync(&pdev->dev); Same comment here. > + pm_runtime_disable(&pdev->dev); > return 0; > } -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
