On Tue, May 6, 2014 at 12:14 AM, Alexandre Courbot <[email protected]> wrote: >> Let's consider my use case for a minute here. I use a table to get gpios >> from a dt node: >> >> /* parse GPIOs */ >> for (; *pin_desc; pin_desc++, gpios++) { >> >> index = of_property_match_string(np, "gpio-names", >> (*pin_desc)->name); >> if (index >= 0) >> *gpios = of_get_gpiod_flags(np, index, NULL); >> >> [...] >> >> } >> >> Now I had no way of knowing that I'm not supposed to use of_get_gpiod_flags. >> Because every other driver uses of_get_gpio(_flags), I used the similarly >> named *public* gpiolib functions, because I like the concept of opaque gpio >> descriptors. > > I am not seeing this "gpio-names" property being used anywhere in > mainline to lookup GPIOs, nor do I see usages of of_get_gpiod_flags() > outside of gpiolib, so I had no way of knowing you decided to use it. > > Besides I don't have a high-level view on your code, but (at first > sight) couldn't your call to of_get_gpiod_flags() simply be replaced > by gpiod_get()?
That was meant to read gpiod_get_index(), sorry for the confusion. Alex. -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
