On Sun, Jun 8, 2014 at 2:12 PM, Alexandre Courbot <[email protected]> wrote: > On Thu, Jun 5, 2014 at 3:22 AM, abdoulaye berthe <[email protected]> wrote:
>> This avoids handling gpiochip remove error in device >> remove handler. >> (...) >> Signed-off-by: abdoulaye berthe <[email protected]> >> - list_del(&chip->list); >> + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags)) >> + panic("gpio: removing gpiochip with gpios still >> requested\n"); > > Really, really I don't think we should panic here. Nope dev_crit() is the right thing, with a big fat warning message. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
