> > > > I don't understand the reason for adding dwapb_read and dwapb_write here. > > The rest of the driver is using readl and writel. I'd rather not see > > two different methods being used in the same driver for register access. > > Maybe I'm missing something, but if we need to add dwapb_read/write, > > then it should be used for all register access. > > Alan, it was my proposal. I rather agree that is better to convert all > accesses to > that. OK, I will convert all readl&writel to dwapb_read&dwapb_write.
- Re: [PATCH 3/3] GPIO: gpio-dwapb: Suspend & Re... atull
- Re: [PATCH 3/3] GPIO: gpio-dwapb: Suspend & Re... Linus Walleij
- RE: [PATCH 3/3] GPIO: gpio-dwapb: Suspend &... Chen, Alvin
- Re: [PATCH 3/3] GPIO: gpio-dwapb: Suspend ... Linus Walleij
- RE: [PATCH 3/3] GPIO: gpio-dwapb: Susp... Chen, Alvin
- [PATCH 2/3] GPIO: gpio-dwapb: Support Debounce Weike Chen
- Re: [PATCH 2/3] GPIO: gpio-dwapb: Support Debounce atull
- Re: [PATCH 2/3] GPIO: gpio-dwapb: Support Debo... Shevchenko, Andriy
- RE: [PATCH 2/3] GPIO: gpio-dwapb: Support ... Chen, Alvin
