On Wed, Oct 22, 2014 at 5:26 PM, Jiri Prchal <[email protected]> wrote: > This patch adds new driver "gpio-of-helper", witch has possibility to export > gpios defined in dt. It exports them in defined name under > /sysfs/class/gpio/name. > It's rebased from Pantelis Antoniou patch to new kernel. > Usage example: > gpio { > compatible = "gpio-of-helper"; > status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_gpio>; > > gsm_on { > gpio-name = "gsm_on"; > gpio = <&pioB 13 GPIO_ACTIVE_HIGH>; > output; > init-low; > }; > }; > > This patch needs Alexey Ignatov [PATCH] gpiolib: allow exporting gpios with > custom names.
We will need to see whether the pre-requisite patch can get merged first, but there are a couple of things that are wrong with your patch anyway: - it is missing a bindings documentation - it is using the legacy integer GPIOs instead of the descriptor interface (see include/linux/gpio/consumer.h). Since this is DT-based, there is absolutely no reason to not use the descriptors interface. - it seems quite long for what it needs to do - the MODULE_AUTHOR has not signed-off this patch (?) But what makes me nervous is that this encourages more usage of the sysfs interface, an in a way that is potentially harmful. Also, I don't know if the DT people will be happy with this idea. Since this concerns DT, please also add the devicetree list and get a Acked-by for the bindings you want to push by a DT maintainer. -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
