Make the serial_mctrl_gpio driver the first user of the new gpiod_set_array
function, which is now available in the linux-gpio devel tree.
All modem control output signals are now set simultaneously.

Signed-off-by: Rojhalat Ibrahim <[email protected]>
Reviewed-by: Alexandre Courbot <[email protected]>
---
Resend: Add Greg Kroah-Hartman and the linux-serial list to the recipients
        in hopes of getting an ACK.

 drivers/tty/serial/serial_mctrl_gpio.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/serial_mctrl_gpio.c 
b/drivers/tty/serial/serial_mctrl_gpio.c
index a3035f9..a38596c 100644
--- a/drivers/tty/serial/serial_mctrl_gpio.c
+++ b/drivers/tty/serial/serial_mctrl_gpio.c
@@ -44,15 +44,21 @@ static const struct {
 void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl)
 {
        enum mctrl_gpio_idx i;
+       struct gpio_desc *desc_array[UART_GPIO_MAX];
+       int value_array[UART_GPIO_MAX];
+       unsigned int count = 0;
 
        if (IS_ERR_OR_NULL(gpios))
                return;
 
        for (i = 0; i < UART_GPIO_MAX; i++)
                if (!IS_ERR_OR_NULL(gpios->gpio[i]) &&
-                   mctrl_gpios_desc[i].dir_out)
-                       gpiod_set_value(gpios->gpio[i],
-                                       !!(mctrl & mctrl_gpios_desc[i].mctrl));
+                   mctrl_gpios_desc[i].dir_out) {
+                       desc_array[count] = gpios->gpio[i];
+                       value_array[count] = !!(mctrl & 
mctrl_gpios_desc[i].mctrl);
+                       count++;
+               }
+       gpiod_set_array(count, desc_array, value_array);
 }
 EXPORT_SYMBOL_GPL(mctrl_gpio_set);
 
--
2.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to