On 2015-02-06 20:21, Uwe Kleine-König wrote:
> Hallo Stefan,
>
> On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote:
>> - memset(info->pin_regs, 0xff, sizeof(*info->pin_regs) * info->npins);
>> +
>> + for (i = 0; i < info->npins; i++) {
>> + info->pin_regs[i].mux_reg = -1;
>> + info->pin_regs[i].conf_reg = -1;
>> + }
> looks definitely better. Just out of interest, did you check if it
> changes the generated code?
Just checked quickly, before it branched to memset. The object file is
24 bytes larger. I guess memset might be a bit faster due to optimized
memory access. But not worth for some error handling relevant
initialization code IMHO...
--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
