Looks good to me Reviewed-by: Ricardo Ribalda Delgado <[email protected]>
On Thu, Feb 12, 2015 at 10:53 PM, Emil Medve <[email protected]> wrote: > WARNING: drivers/gpio/built-in.o(.text+0x3962): Section mismatch in reference > from the function mpc8xxx_probe() to the variable .init.data:mpc8xxx_gpio_ids > The function mpc8xxx_probe() references > the variable __initdata mpc8xxx_gpio_ids. > This is often because mpc8xxx_probe lacks a __initdata > annotation or the annotation of mpc8xxx_gpio_ids is wrong. > > WARNING: drivers/gpio/built-in.o(.text+0x396a): Section mismatch in reference > from the function mpc8xxx_probe() to the variable .init.data:mpc8xxx_gpio_ids > The function mpc8xxx_probe() references > the variable __initdata mpc8xxx_gpio_ids. > This is often because mpc8xxx_probe lacks a __initdata > annotation or the annotation of mpc8xxx_gpio_ids is wrong. > > WARNING: drivers/gpio/built-in.o(.data+0x48): Section mismatch in reference > from the variable mpc8xxx_plat_driver to the variable > .init.data:mpc8xxx_gpio_ids > The variable mpc8xxx_plat_driver references > the variable __initdata mpc8xxx_gpio_ids > If the reference is valid then annotate the > variable with __init* or __refdata (see linux/init.h) or name the variable: > *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console > > Introduced in '98686d9a5 gpio: mpc8xxx: Convert to platform device interface' > > Signed-off-by: Emil Medve <[email protected]> > --- > drivers/gpio/gpio-mpc8xxx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c > index a6952ba3..59c4c11 100644 > --- a/drivers/gpio/gpio-mpc8xxx.c > +++ b/drivers/gpio/gpio-mpc8xxx.c > @@ -334,7 +334,7 @@ static struct irq_domain_ops mpc8xxx_gpio_irq_ops = { > .xlate = irq_domain_xlate_twocell, > }; > > -static struct of_device_id mpc8xxx_gpio_ids[] __initdata = { > +static const struct of_device_id mpc8xxx_gpio_ids[] = { > { .compatible = "fsl,mpc8349-gpio", }, > { .compatible = "fsl,mpc8572-gpio", }, > { .compatible = "fsl,mpc8610-gpio", }, > -- > 2.3.0 > -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
