Hi Laurent,
On Thu, Mar 5, 2015 at 10:14 AM, Laurent Pinchart
<[email protected]> wrote:
>> @@ -230,11 +229,12 @@ static void sh_pfc_write_config_reg(struct sh_pfc
>> *pfc,
>>
>> static int sh_pfc_get_config_reg(struct sh_pfc *pfc, u16 enum_id,
>> const struct pinmux_cfg_reg **crp, int
>> *fieldp,
>> - int *valuep)
>> + u32 *valuep)
>> {
>> const struct pinmux_cfg_reg *config_reg;
>> - unsigned long r_width, f_width, curr_width, ncomb;
>> - unsigned int k, m, n, pos, bit_pos;
>> + unsigned long r_width, f_width, curr_width;
>> + unsigned int k, m, pos, bit_pos;
>> + u32 ncomb, n;
>
> Nitpicking, strictly speaking ncomb and n are not register data, but using u32
> for them seems good to me.
n is assigned to the (partial) register value output parameter, so it is.
ncomb is an upper boundary for n.
And I didn't want to split this off to yet another patch ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
