On Wednesday 11 March 2015 12:24:38 Linus Walleij wrote: > Commit 1feb57a245a4910b03202a814ffc51a900bd4aca > "gpio: add parameter to allow the use named gpios" > includes a double-conted array. Fix this. > > Reported-by: Dan Carpenter <[email protected]> > Cc: Olliver Schinagl <[email protected]> > Signed-off-by: Linus Walleij <[email protected]> > --- > drivers/gpio/devres.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/devres.c b/drivers/gpio/devres.c > index ec24da2418b3..0bd060bf7151 100644 > --- a/drivers/gpio/devres.c > +++ b/drivers/gpio/devres.c > @@ -135,7 +135,7 @@ struct gpio_desc *devm_get_gpiod_from_child(struct device > *dev, > const char *con_id, > struct fwnode_handle *child) > { > - static const char const *suffixes[] = { "gpios", "gpio" }; > + static const char *suffixes[] = { "gpios", "gpio" }; > char prop_name[32]; /* 32 is max size of property name */ > struct gpio_desc **dr; > struct gpio_desc *desc; >
Shouldn't it be const char * const suffixes[], as in a const pointer to const data? Wouldn't it be better to add an #include "gpiolib.h" to devres.c and use the gpio_suffixes array defined in gliolib.h? -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
