Hello Mark,
On 02.06.2015 22:41, Mark Brown wrote:
> On Tue, Jun 02, 2015 at 02:09:15AM +0300, Vladimir Zapolskiy wrote:
>
>> @@ -1783,18 +1783,13 @@ static int wm8903_gpio_direction_in(struct gpio_chip
>> *chip, unsigned offset)
>> {
>> struct wm8903_priv *wm8903 = gpio_to_wm8903(chip);
>> unsigned int mask, val;
>> - int ret;
>>
>> mask = WM8903_GPn_FN_MASK | WM8903_GPn_DIR_MASK;
>> val = (WM8903_GPn_FN_GPIO_INPUT << WM8903_GPn_FN_SHIFT) |
>> WM8903_GPn_DIR;
>>
>> - ret = regmap_update_bits(wm8903->regmap,
>> - WM8903_GPIO_CONTROL_1 + offset, mask, val);
>> - if (ret < 0)
>> - return ret;
>> -
>> - return 0;
>> + return regmap_update_bits(wm8903->regmap,
>> + WM8903_GPIO_CONTROL_1 + offset, mask, val);
>> }
>>
>> static int wm8903_gpio_get(struct gpio_chip *chip, unsigned offset)
>
> This appears to be an unrelated coding style change.
>
this particular patch is named "simplify gpiolib callbacks".
Do you prefer to separate the change here in .direction_in
implementation from the rest?
--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
