The DT describes gpios with subnodes. These subnodes can contain a
property 'line-name'. This information can be useful in other areas
where we want to identify a GPIO by its name.
This patch stores the line-name in the gpio descriptor.
Signed-off-by: Markus Pargmann <m...@pengutronix.de>
---
drivers/gpio/gpiolib-of.c | 30 +++++++++++++++++++++---------
1 file changed, 21 insertions(+), 9 deletions(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index fea80bbccf12..1911b692f735 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -184,11 +184,6 @@ static struct gpio_desc *of_parse_own_gpio(struct
device_node *np,
*dflags |= GPIOD_OUT_LOW;
else if (of_property_read_bool(np, "output-high"))
*dflags |= GPIOD_OUT_HIGH;
- else {
- pr_warn("GPIO line %d (%s): no hogging state specified, bailing
out\n",
- desc_to_gpio(gg_data.out_gpio), np->name);
- return ERR_PTR(-EINVAL);
- }
if (name && of_property_read_string(np, "line-name", name))
*name = np->name;
@@ -214,15 +209,32 @@ static void of_gpiochip_scan_gpios(struct gpio_chip *chip)
enum gpiod_flags dflags;
for_each_child_of_node(chip->of_node, np) {
- if (!of_property_read_bool(np, "gpio-hog"))
- continue;
+ struct gpio_desc *name_desc;
desc = of_parse_own_gpio(np, &name, &lflags, &dflags);
if (IS_ERR(desc))
continue;
- if (gpiod_hog(desc, name, lflags, dflags))
- continue;
+ name_desc = gpio_name_to_desc(name);
+ if (name_desc)
+ dev_warn(chip->dev, "GPIO name collision for '%s'
detected at GPIO line %d (%s)\n",
+ name, desc_to_gpio(desc), np->name);
+ else if (desc->name)
+ dev_warn(chip->dev, "GPIO has already a name '%s' new
name would be '%s' at GPIO %d\n",
+ desc->name, name, desc_to_gpio(desc));
+ else
+ desc->name = name;
+
+ if (of_property_read_bool(np, "gpio-hog")) {
+ if (!dflags) {
+ pr_warn("GPIO line %d (%s): no hogging state
specified, bailing out\n",
+ desc_to_gpio(desc), np->name);
+ continue;
+ }
+
+ if (gpiod_hog(desc, name, lflags, dflags))
+ continue;
+ }
}
}
--
2.4.6
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
