On Mon, Aug 3, 2015 at 1:15 AM, Alexey Khoroshilov <[email protected]> wrote: > Dear colleagus, > > grgpio_irq_unmap() code looks quite suspicious regarding usage of > priv->bgc.lock spinlock. > > It locks the spinlock in line 310: > spin_lock_irqsave(&priv->bgc.lock, flags); > and then it can call grgpio_set_imask() in line 317: > grgpio_set_imask(priv, i, 0); > > But grgpio_set_imask() unconditionally locks the spinlock by itself.
Indeed, this looks plain wrong. I have sent a fix that moves the spinlock acquisition outside of grgpio_set_imask(). -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
