On Tue, Aug 18, 2015 at 1:10 PM, Grygorii Strashko <[email protected]> wrote:
> As per CCF documentation (clk.txt) the clk_prepare/unprepare APIs > are not allowed in atomic context. But now OMAP GPIO driver > uses them while applying debounce settings and as part > of PM runtime irqsafe operations: > > - omap_gpio_debounce() is holding the lock with IRQs off. > + omap2_set_gpio_debounce() > + clk_prepare_enable() > + clk_prepare() this one might sleep. > > - pm_runtime_get_sync() is holding the lock with IRQs off > + omap_gpio_runtime_suspend() > + raw_spin_lock_irqsave() > + omap_gpio_dbck_disable() > + clk_disable_unprepare() > > Hence, fix it by moeving dbclk prepare/unprepare in OMAP GPIO > omap_gpio_probe/omap_gpio_remove. Also, while here, ensure that > debounce functionality is disabled if clk_get() failed, > because otherwise kernel will carsh in omap2_set_gpio_debounce(). > > Reported-by: Sebastian Andrzej Siewior <[email protected]> > Signed-off-by: Grygorii Strashko <[email protected]> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
