On Fri, Aug 28, 2015 at 8:44 PM, Tony Lindgren <t...@atomide.com> wrote:
> Currently we gpio-omap breaks if gpiochip_add() returns -EPROBE_DEFER:
>
> [ 0.570000] gpiochip_add: GPIOs 0..31 (gpio) failed to register
> [ 0.570000] omap_gpio 48310000.gpio: Could not register gpio chip -517
> ...
> [ 3.670000] omap_gpio 48310000.gpio: Unbalanced pm_runtime_enable!
>
> Let's fix the issue by adding the missing pm_runtime_put() on error.
>
> Cc: Grygorii Strashko <grygorii.stras...@ti.com>
> Cc: Javier Martinez Canillas <jav...@dowhile0.org>
> Cc: Kevin Hilman <khil...@deeprootsystems.com>
> Cc: Santosh Shilimkar <ssant...@kernel.org>
> Signed-off-by: Tony Lindgren <t...@atomide.com>
> ---
> drivers/gpio/gpio-omap.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index b0c57d5..f09bf0b 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1232,8 +1232,11 @@ static int omap_gpio_probe(struct platform_device
> *pdev)
> omap_gpio_mod_init(bank);
>
> ret = omap_gpio_chip_init(bank, irqc);
> - if (ret)
> + if (ret) {
> + pm_runtime_put_sync(bank->dev);
> + pm_runtime_disable(bank->dev);
> return ret;
> + }
>
> omap_gpio_show_rev(bank);
Patch applied for fixes with Santosh's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
