Hi Morimoto-san,
On Thu, Sep 17, 2015 at 6:10 AM, Kuninori Morimoto
<kuninori.morimoto...@renesas.com> wrote:
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
> @@ -1775,6 +1775,183 @@ static const unsigned int scif5_clk_mux[] = {
> SCK5_MARK,
> };
>
> +/* - SSI
> -------------------------------------------------------------------- */
> +static const unsigned int ssi0_data_pins[] = {
> + /* SDATA */
> + RCAR_GP_PIN(6, 2),
> +};
> +static const unsigned int ssi0_data_mux[] = {
> + SSI_SDATA0_MARK,
> +};
> +static const unsigned int ssi01239_ctrl_pins[] = {
> + /* SCK, WS */
> + RCAR_GP_PIN(6, 0), RCAR_GP_PIN(6, 1),
> +};
> +static const unsigned int ssi01239_ctrl_mux[] = {
> + SSI_SCK0129_MARK, SSI_WS0129_MARK,
> +};
> +static const unsigned int ssi1_a_data_pins[] = {
Shouldn't this be "ssi1_data_a_pins" for consistency with other devices?
Likewise for the other added entries.
The rest looks OK, so if you fix these, you can add my
Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>
> + /* SDATA */
> + RCAR_GP_PIN(6, 3),
> +};
> +static const unsigned int ssi1_a_data_mux[] = {
> + SSI_SDATA1_A_MARK,
> +};
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
