Hi Sergei,
Thank you for the patch.
On Wednesday 23 September 2015 01:06:21 Sergei Shtylyov wrote:
> R8A7790/1 PFC drivers use almost identical 'union vin_data' and completely
> identical VIN_DATA_PIN_GROUP() macro; we thus can move them into the
> shared header file...
>
> Suggested-by: Geert Uytterhoeven <ge...@linux-m68k.org>
> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>
> Acked-by: Geert Uytterhoeven <geert+rene...@glider.be>
>
> ---
> The patch is against the 'devel' branch of Linus W.'s 'linux-pinctrl.git'
> repo.
>
> Changed in version 2:
> - removed leftover empty line from the R8A7790 driver;
> - added Geert's ACK.
>
> drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 19 -------------------
> drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 18 ------------------
> drivers/pinctrl/sh-pfc/sh_pfc.h | 18 ++++++++++++++++++
> 3 files changed, 18 insertions(+), 37 deletions(-)
>
> Index: renesas/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> ===================================================================
> --- renesas.orig/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> +++ renesas/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> @@ -3624,25 +3624,6 @@ static const unsigned int usb2_pins[] =
> static const unsigned int usb2_mux[] = {
> USB2_PWEN_MARK, USB2_OVC_MARK,
> };
> -
> -union vin_data {
> - unsigned int data24[24];
> - unsigned int data20[20];
> - unsigned int data16[16];
> - unsigned int data12[12];
> - unsigned int data10[10];
> - unsigned int data8[8];
> - unsigned int data4[4];
> -};
> -
> -#define VIN_DATA_PIN_GROUP(n, s) \
> - { \
> - .name = #n#s, \
> - .pins = n##_pins.data##s, \
> - .mux = n##_mux.data##s, \
> - .nr_pins = ARRAY_SIZE(n##_pins.data##s), \
> - }
> -
> /* - VIN0 -------------------------------------------------------------- */
> static const union vin_data vin0_data_pins = {
> .data24 = {
> Index: renesas/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> ===================================================================
> --- renesas.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> +++ renesas/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> @@ -3986,24 +3986,6 @@ static const unsigned int usb1_mux[] = {
> USB1_PWEN_MARK,
> USB1_OVC_MARK,
> };
> -
> -union vin_data {
> - unsigned int data24[24];
> - unsigned int data20[20];
> - unsigned int data16[16];
> - unsigned int data12[12];
> - unsigned int data10[10];
> - unsigned int data8[8];
> -};
> -
> -#define VIN_DATA_PIN_GROUP(n, s) \
> - { \
> - .name = #n#s, \
> - .pins = n##_pins.data##s, \
> - .mux = n##_mux.data##s, \
> - .nr_pins = ARRAY_SIZE(n##_pins.data##s), \
> - }
> -
> /* - VIN0 -------------------------------------------------------------- */
> static const union vin_data vin0_data_pins = {
> .data24 = {
> Index: renesas/drivers/pinctrl/sh-pfc/sh_pfc.h
> ===================================================================
> --- renesas.orig/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ renesas/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -52,6 +52,24 @@ struct sh_pfc_pin_group {
> unsigned int nr_pins;
> };
The sh_pfc.h file is getting a bit messy, so I'd just add a comment here to
tell what the macro and union are about.
Apart from that,
Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> +#define VIN_DATA_PIN_GROUP(n, s) \
> + { \
> + .name = #n#s, \
> + .pins = n##_pins.data##s, \
> + .mux = n##_mux.data##s, \
> + .nr_pins = ARRAY_SIZE(n##_pins.data##s), \
> + }
> +
> +union vin_data {
> + unsigned int data24[24];
> + unsigned int data20[20];
> + unsigned int data16[16];
> + unsigned int data12[12];
> + unsigned int data10[10];
> + unsigned int data8[8];
> + unsigned int data4[4];
> +};
> +
> #define SH_PFC_FUNCTION(n) \
> { \
> .name = #n, \
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
