Hi Linus 2015-11-05 22:40 GMT+09:00 Linus Walleij <linus.wall...@linaro.org>: > On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada > <yamada.masah...@socionext.com> wrote: > >> ARCH_SUNXI selects RESET_CONTROLLER. >> The dependency "depends on RESET_CONTROLLER" is already met. >> >> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> > > NACK, this pin controller needs that as dependency, I don't worry > that it's overspecified. > > They both do this: > #include <linux/reset.h> > > And the object should specify its dependencies, not rely on them > being implicitly available. > > The dep is there for human readers too, not just machines. And to > them, this is helpful information.
How strict we should follow this rule? Many drivers depend on OF, but do they all have "depends on OF"? -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
