Hi Geert Thank you for your review
> > +#define PORT_GP_CFG_8(bank, fn, sfx, cfg) > > \ > > + PORT_GP_CFG_4(bank, fn, sfx, cfg), > > \ > > PORT_GP_CFG_1(bank, 4, fn, sfx, cfg), PORT_GP_CFG_1(bank, 5, fn, > > sfx, cfg), \ > > - PORT_GP_CFG_1(bank, 6, fn, sfx, cfg), PORT_GP_CFG_1(bank, 7, fn, > > sfx, cfg), \ > > + PORT_GP_CFG_1(bank, 6, fn, sfx, cfg), PORT_GP_CFG_1(bank, 7, fn, > > sfx, cfg) > > +#define PORT_GP_8(bank, fn, sfx) PORT_GP_CFG_8(bank, fn, sfx, 0) > > + > > +#define PORT_GP_CFG_9(bank, fn, sfx, cfg) > > \ > > + PORT_GP_CFG_8(bank, fn, sfx, cfg), > > \ > > + PORT_GP_CFG_1(bank, 8, fn, sfx, cfg) > > +#define PORT_GP_9(bank, fn, sfx) PORT_GP_CFG_9(bank, fn, sfx, 0) > > + > > +#define PORT_GP_CFG_12(bank, fn, sfx, cfg) > > \ > > + PORT_GP_CFG_8(bank, fn, sfx, cfg), > > \ > > PORT_GP_CFG_1(bank, 8, fn, sfx, cfg), PORT_GP_CFG_1(bank, 9, fn, > > sfx, cfg), \ > > - PORT_GP_CFG_1(bank, 10, fn, sfx, cfg), PORT_GP_CFG_1(bank, 11, fn, > > sfx, cfg), \ > > - PORT_GP_CFG_1(bank, 12, fn, sfx, cfg), PORT_GP_CFG_1(bank, 13, fn, > > sfx, cfg), \ > > - PORT_GP_CFG_1(bank, 14, fn, sfx, cfg), PORT_GP_CFG_1(bank, 15, fn, > > sfx, cfg), \ > > - PORT_GP_CFG_1(bank, 16, fn, sfx, cfg), PORT_GP_CFG_1(bank, 17, fn, > > sfx, cfg), \ > > + PORT_GP_CFG_1(bank, 10, fn, sfx, cfg), PORT_GP_CFG_1(bank, 11, fn, > > sfx, cfg) > > +#define PORT_GP_12(bank, fn, sfx) PORT_GP_CFG_12(bank, fn, sfx, 0) > > The *_8 and *_12 definitions don't seem to be used (except for defining > later variants in the series)? I think _12 is used in pfc-sh7734.c ? I added _8 because pfc-r8a7779.c is using _9. I don't like odd number definition. -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
